Thanks

Thanks for your edit! I hope this fixes the issue. -- Bennie (talk ~ fellows) 20:38, August 22, 2016 (UTC)

MediaWiki:Calculators/Code.js

Hey Mark,

Lazy loading is not the problem. You're adding a ton of null checks when the problem is precisely that the value you're checking is null. While Lazy Loading is the reason it suddenly broke, a coincidental issue with the code was that it was using the wrong ID to find a list of items. Compare the screenshots in the gallery below.

My version. Notice how it works, even without the lazy loading features you added.

Your version. Notice the difference in lists. It's listing every possible item, instead of a limited set of selected items as in mine. Your edit delayed code execution so that these values actually exist, but we don't really care that they don't exist at this point - that was the bug, we used the wrong ID.

Therefore, I would recommend submitting this revision, not your latest one. Whether those null checks and execution delay be added is entirely up to you, but it shouldn't affect the functionality of the code.

-- Sixorish (talk) 04:18, January 26, 2018 (UTC)

Thanks, I forgot Oasis was a thing. I reverted back to your revision and implemented my own fixes on top of it. Now the functionality should work on both Monobook and Oasis. -- Sixorish (talk) 05:46, January 26, 2018 (UTC)